-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: update cucumber format parsing #284
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhan83
reviewed
Nov 22, 2024
mhan83
reviewed
Nov 22, 2024
tianfeng92
changed the title
feat: update cucumber format parsing
feat!: update cucumber format parsing
Nov 25, 2024
mhan83
reviewed
Nov 25, 2024
alexplischke
approved these changes
Nov 25, 2024
mhan83
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cucumber is transitioning to a quoted format for type and path configurations, deprecating unquoted formats. Our current implementation does not support parsing the quoted format. This PR resolves the issue by adding support for quoted format parsing. Stop supporting
file://C:\custom\formatter
pattern as it's ambiguous to proceed the input and hard to understand the error message. Docs will also be addressed.macOS:
✅ Cucumber@11: https://app.saucelabs.com/tests/01f4f809b8b14bb5a61f6fa87a5775f0
✅ [email protected]: https://app.saucelabs.com/tests/60e70b1f1b6443618c35cf7ba5308651
✅ [email protected]: https://app.saucelabs.com/tests/5e2753cee2cb494fbf04eff46bc48789
Windows:
✅ [email protected]: https://app.saucelabs.com/tests/3a904aab3e4a4ced815cbbdb754a83db
✅ [email protected]: https://app.saucelabs.com/tests/9f4ff5141f054ab1bcff1886fe8446f2
⛔ Cucumber@10 and Cucumber@11 failed due to our known issue. https://app.saucelabs.com/tests/12193fa2d3364482bde9652a9a5bad57
Note: The file URI pattern in the path field, such as
"html":"file://output_file"
, is not supported. The file will fail to generate without any error or warning.I'll also add docs for the format patterns.