Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: update cucumber format parsing #284

Merged
merged 24 commits into from
Nov 25, 2024
Merged

feat!: update cucumber format parsing #284

merged 24 commits into from
Nov 25, 2024

Conversation

tianfeng92
Copy link
Contributor

@tianfeng92 tianfeng92 commented Nov 20, 2024

Description

Cucumber is transitioning to a quoted format for type and path configurations, deprecating unquoted formats. Our current implementation does not support parsing the quoted format. This PR resolves the issue by adding support for quoted format parsing. Stop supporting file://C:\custom\formatter pattern as it's ambiguous to proceed the input and hard to understand the error message. Docs will also be addressed.

macOS:
✅ Cucumber@11: https://app.saucelabs.com/tests/01f4f809b8b14bb5a61f6fa87a5775f0
[email protected]: https://app.saucelabs.com/tests/60e70b1f1b6443618c35cf7ba5308651
[email protected]: https://app.saucelabs.com/tests/5e2753cee2cb494fbf04eff46bc48789

Windows:
[email protected]: https://app.saucelabs.com/tests/3a904aab3e4a4ced815cbbdb754a83db
[email protected]: https://app.saucelabs.com/tests/9f4ff5141f054ab1bcff1886fe8446f2
⛔ Cucumber@10 and Cucumber@11 failed due to our known issue. https://app.saucelabs.com/tests/12193fa2d3364482bde9652a9a5bad57

Note: The file URI pattern in the path field, such as "html":"file://output_file", is not supported. The file will fail to generate without any error or warning.

I'll also add docs for the format patterns.

@tianfeng92 tianfeng92 marked this pull request as ready for review November 22, 2024 16:22
@tianfeng92 tianfeng92 requested a review from a team as a code owner November 22, 2024 16:22
src/cucumber-runner.ts Outdated Show resolved Hide resolved
@tianfeng92 tianfeng92 requested a review from mhan83 November 22, 2024 17:49
src/cucumber-runner.ts Outdated Show resolved Hide resolved
@tianfeng92 tianfeng92 marked this pull request as draft November 22, 2024 23:04
@tianfeng92 tianfeng92 marked this pull request as ready for review November 23, 2024 17:56
@tianfeng92 tianfeng92 changed the title feat: update cucumber format parsing feat!: update cucumber format parsing Nov 25, 2024
src/types.ts Outdated Show resolved Hide resolved
@tianfeng92 tianfeng92 merged commit 3fb15d8 into main Nov 25, 2024
27 checks passed
@tianfeng92 tianfeng92 deleted the DEVX-3107 branch November 25, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants